Update #103: Creation of remote hdmicec client #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TB-1993
force-pushed
the
feature/gh103_create_remote_cec-client
branch
from
db9c508 to
17ffc04
Compare
Ulrond
previously requested changes
Nov 8, 2024
Ulrond
reviewed
Nov 8, 2024
This was
unlinked from
issues
Nov 27, 2024
|
The new versions of these still have issues, the remoteCECClient isn't consistent due to the implementation of the readUntil in the sshConsole. I'll raise a bug ticket to get this fixed. |
Moved stream handling to it's own module and added a receiveMessage method to hdmiCECController
TB-1993
force-pushed
the
feature/gh103_create_remote_cec-client
branch
from
fc14435 to
f25a966
Compare
TB-1993
commented
Dec 19, 2024
retries Corrected hdmiController code to consistently use streamToFile's readUnitl method
Changed receiveMessage to checkMessageReceived to allow for a receiveMessage method that returns the received message to be implemented in the future.
TB-1993
force-pushed
the
feature/gh103_create_remote_cec-client
branch
from
a72e3ac to
3b0d502
Compare
TB-1993
dismissed
Ulrond’s stale review
The code has moved on to fit other requirements so the review is no longer relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new remote-cec-client hdmi cec controller.
Also added a threaded logging function to allow the logModule to write a continuous log stream out to a file.
closes #107